-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate devices, empty lines and refactor entities #32
Open
tomleglaunec
wants to merge
19
commits into
hekmon:main
Choose a base branch
from
tomleglaunec:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ections in device info
…ns that do not have by-id mechanism
Update setup and ConfigEntry
refactor status register handling fix absolute import remove unecessary waiting (now handled by async_setup) change serial function to property
fix debug messages number of args fix log flood of availability infos
change device class for consistency add custom on/off icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Résolution de bogues :
by-id
lorsque disponible (2 appareil détecté #27)Failed to parse: b''
Error in historic mode: 'b' #26, même si la racine du problème est l'interface série qui remplacerait lesCR
par desLF
)Factorisation :
Changements :
BinarySensorDeviceClass
à ajuster)IMPORTANT : N'ayant qu'un compteur linky en mode standard, je n'ai pas pu vérifier que les modifications ne cassent pas le mode historique, si quelqu'un pouvait m'envoyer une capture de quelques trames historiques, je pourrai tester l'intégration
Les PR ne devraient pas être aussi fourre-tout, au risque de les rendre indigeste, en espérant que la relecture ne sera pas trop dure 😅