Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix PHP warnings for undefined array key #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUGFIX] Fix PHP warnings for undefined array key #90

wants to merge 1 commit into from

Conversation

theLine
Copy link

@theLine theLine commented Feb 23, 2023

No description provided.

helhum
helhum reviewed Feb 24, 2023
View reviewed changes
Classes/Mvc/RequestBuilder.php Outdated Show resolved Hide resolved
Classes/Uri/TyposcriptRenderingUri.php Show resolved Hide resolved
helhum
helhum requested changes Feb 27, 2023
View reviewed changes
Copy link
Owner

@helhum helhum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge if you remove the array_key_exists

@helhum
Copy link
Owner

helhum commented Feb 27, 2023

Not sure what the failing tests mean, though :-/

@mediaessenz
Copy link

mediaessenz commented Apr 8, 2023 •
edited
Loading

All failed tests calling urls containing the language slug "da/".

I can't find any definition of this slug inside the test data. Maybe this is the reason, why they fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helhum helhum helhum requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theLine @helhum @mediaessenz