update helium-lib to take router_key as a string #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
router keys are normally ecc-compact keys, those cannot be turned into solana Pubkeys. But they can still be used to derive the escrow accounts from. Updating helium-lib, it has moved from using a regular solana::Transaction to solana::VersionedTransaction.
andymck
approved these changes
Feb 14, 2025
michaeldjeffrey
force-pushed
the
mj/router-key-string
branch
from
bd0f94d to
9b95e6c
Compare
michaeldjeffrey
force-pushed
the
mj/router-key-string
branch
from
9b95e6c to
ecc8855
Compare
provides solana Keypair -> helium-lib Keypair From impls
bbalser
approved these changes
Feb 14, 2025
macpie
approved these changes
Feb 14, 2025
michaeldjeffrey
added a commit
that referenced
this pull request
Feb 25, 2025
This reverts commit fc57aaa.
michaeldjeffrey
added a commit
that referenced
this pull request
Feb 26, 2025
* Revert "update helium-lib to correctly calculate epoch info key (#950)" This reverts commit 59e3a88. * Revert "Add skip_preflight setting for solana rpc (#949)" This reverts commit 22d0393. * Revert "Do not log RPC url (#948)" This reverts commit 66bf4c1. * Revert "Min Priority Fee Setting (#947)" This reverts commit 72fe9b4. * Revert "use the correct subdao when finding delegate and escrow accounts (#946)" This reverts commit 41e48fb. * Revert "update helium-lib to take router_key as a string (#943)" This reverts commit fc57aaa. * Revert "read solana keypair, convert to helium keypair (#942)" This reverts commit 6e7b65b. * Revert "Helium Lib attempt: 2 (#930)" This reverts commit dfa2c08.
macpie
pushed a commit
that referenced
this pull request
Feb 28, 2025
* Revert "update helium-lib to correctly calculate epoch info key (#950)" This reverts commit 59e3a88. * Revert "Add skip_preflight setting for solana rpc (#949)" This reverts commit 22d0393. * Revert "Do not log RPC url (#948)" This reverts commit 66bf4c1. * Revert "Min Priority Fee Setting (#947)" This reverts commit 72fe9b4. * Revert "use the correct subdao when finding delegate and escrow accounts (#946)" This reverts commit 41e48fb. * Revert "update helium-lib to take router_key as a string (#943)" This reverts commit fc57aaa. * Revert "read solana keypair, convert to helium keypair (#942)" This reverts commit 6e7b65b. * Revert "Helium Lib attempt: 2 (#930)" This reverts commit dfa2c08.
macpie
pushed a commit
that referenced
this pull request
Feb 28, 2025
* Revert "update helium-lib to correctly calculate epoch info key (#950)" This reverts commit 59e3a88. * Revert "Add skip_preflight setting for solana rpc (#949)" This reverts commit 22d0393. * Revert "Do not log RPC url (#948)" This reverts commit 66bf4c1. * Revert "Min Priority Fee Setting (#947)" This reverts commit 72fe9b4. * Revert "use the correct subdao when finding delegate and escrow accounts (#946)" This reverts commit 41e48fb. * Revert "update helium-lib to take router_key as a string (#943)" This reverts commit fc57aaa. * Revert "read solana keypair, convert to helium keypair (#942)" This reverts commit 6e7b65b. * Revert "Helium Lib attempt: 2 (#930)" This reverts commit dfa2c08.
macpie
pushed a commit
that referenced
this pull request
Feb 28, 2025
* Revert "update helium-lib to correctly calculate epoch info key (#950)" This reverts commit 59e3a88. * Revert "Add skip_preflight setting for solana rpc (#949)" This reverts commit 22d0393. * Revert "Do not log RPC url (#948)" This reverts commit 66bf4c1. * Revert "Min Priority Fee Setting (#947)" This reverts commit 72fe9b4. * Revert "use the correct subdao when finding delegate and escrow accounts (#946)" This reverts commit 41e48fb. * Revert "update helium-lib to take router_key as a string (#943)" This reverts commit fc57aaa. * Revert "read solana keypair, convert to helium keypair (#942)" This reverts commit 6e7b65b. * Revert "Helium Lib attempt: 2 (#930)" This reverts commit dfa2c08.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helium-libPR :: helium/helium-wallet-rs#457router keys are normally ecc-compact keys, those cannot be turned into solana Pubkeys. But they can still be used to derive the escrow accounts from.
Updating helium-lib, it has moved from using a regular
solana::Transactiontosolana::VersionedTransaction.