Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip_preflight setting for solana rpc #949

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Add skip_preflight setting for solana rpc #949

merged 1 commit into from
Feb 19, 2025

Conversation

michaeldjeffrey
Copy link
Contributor

@michaeldjeffrey michaeldjeffrey commented Feb 18, 2025 •
edited
Loading

In Oracle's we have historically had skip_preflight: true for all txns.
There have been updates to helium-lib that we cannot debug if preflight checks are skipped.
This PR turns it into a setting, so it can toggle when we need better errors.

@michaeldjeffrey
Add skip_preflight setting for solana rpc
86ed142 
by default we skip_preflight checks, but we get better errors if we can
fail in a preflight
andymck
andymck reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@andymck andymck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so to confirm, the skip_preflight setting will be configured with a value of false and thus the preflight checks will be performed?

And isnt 'false' the default value on the sendTransaction API if not specified ?

@michaeldjeffrey
Copy link
Contributor Author

so to confirm, the skip_preflight setting will be configured with a value of false and thus the preflight checks will be performed?

And isnt 'false' the default value on the sendTransaction API if not specified ?

Good question, I was unclear in my description (has been updated).
Oracles has hardcoded skip_preflight: true where txns are sent.
This was generally safe as we sent those txns often and knew they were constructed properly.

The lastest update from helium-lib changes the Txn type to a VersionedTransaction.
It seems to me that this change should not cause any problems, but something is going wrong, and performing preflight checks is a way that we can get errors from solana that are hopefully better than "The thing didn't happen".

In short, Solana's default is perform preflight checks. Oracle's default was to skip.
Now it's a setting.

@michaeldjeffrey michaeldjeffrey merged commit 22d0393 into main Feb 19, 2025
17 checks passed
@michaeldjeffrey michaeldjeffrey deleted the mj/skip-preflight-setting branch February 19, 2025 16:58
michaeldjeffrey added a commit that referenced this pull request Feb 25, 2025
@michaeldjeffrey
Revert "Add skip_preflight setting for solana rpc (#949)"
09b4cc4 
This reverts commit 22d0393.
michaeldjeffrey added a commit that referenced this pull request Feb 26, 2025
@michaeldjeffrey
Revert Helium Lib 2 (#957)
5b16e1f 
* Revert "update helium-lib to correctly calculate epoch info key (#950)"

This reverts commit 59e3a88.

* Revert "Add skip_preflight setting for solana rpc (#949)"

This reverts commit 22d0393.

* Revert "Do not log RPC url (#948)"

This reverts commit 66bf4c1.

* Revert "Min Priority Fee Setting (#947)"

This reverts commit 72fe9b4.

* Revert "use the correct subdao when finding delegate and escrow accounts (#946)"

This reverts commit 41e48fb.

* Revert "update helium-lib to take router_key as a string (#943)"

This reverts commit fc57aaa.

* Revert "read solana keypair, convert to helium keypair (#942)"

This reverts commit 6e7b65b.

* Revert "Helium Lib attempt: 2 (#930)"

This reverts commit dfa2c08.
macpie pushed a commit that referenced this pull request Feb 28, 2025
@michaeldjeffrey @macpie
Revert Helium Lib 2 (#957)
5fefe51 
* Revert "update helium-lib to correctly calculate epoch info key (#950)"

This reverts commit 59e3a88.

* Revert "Add skip_preflight setting for solana rpc (#949)"

This reverts commit 22d0393.

* Revert "Do not log RPC url (#948)"

This reverts commit 66bf4c1.

* Revert "Min Priority Fee Setting (#947)"

This reverts commit 72fe9b4.

* Revert "use the correct subdao when finding delegate and escrow accounts (#946)"

This reverts commit 41e48fb.

* Revert "update helium-lib to take router_key as a string (#943)"

This reverts commit fc57aaa.

* Revert "read solana keypair, convert to helium keypair (#942)"

This reverts commit 6e7b65b.

* Revert "Helium Lib attempt: 2 (#930)"

This reverts commit dfa2c08.
macpie pushed a commit that referenced this pull request Feb 28, 2025
@michaeldjeffrey @macpie
Revert Helium Lib 2 (#957)
c5d7fd9 
* Revert "update helium-lib to correctly calculate epoch info key (#950)"

This reverts commit 59e3a88.

* Revert "Add skip_preflight setting for solana rpc (#949)"

This reverts commit 22d0393.

* Revert "Do not log RPC url (#948)"

This reverts commit 66bf4c1.

* Revert "Min Priority Fee Setting (#947)"

This reverts commit 72fe9b4.

* Revert "use the correct subdao when finding delegate and escrow accounts (#946)"

This reverts commit 41e48fb.

* Revert "update helium-lib to take router_key as a string (#943)"

This reverts commit fc57aaa.

* Revert "read solana keypair, convert to helium keypair (#942)"

This reverts commit 6e7b65b.

* Revert "Helium Lib attempt: 2 (#930)"

This reverts commit dfa2c08.
macpie pushed a commit that referenced this pull request Feb 28, 2025
@michaeldjeffrey @macpie
Revert Helium Lib 2 (#957)
7eb1ddd 
* Revert "update helium-lib to correctly calculate epoch info key (#950)"

This reverts commit 59e3a88.

* Revert "Add skip_preflight setting for solana rpc (#949)"

This reverts commit 22d0393.

* Revert "Do not log RPC url (#948)"

This reverts commit 66bf4c1.

* Revert "Min Priority Fee Setting (#947)"

This reverts commit 72fe9b4.

* Revert "use the correct subdao when finding delegate and escrow accounts (#946)"

This reverts commit 41e48fb.

* Revert "update helium-lib to take router_key as a string (#943)"

This reverts commit fc57aaa.

* Revert "read solana keypair, convert to helium keypair (#942)"

This reverts commit 6e7b65b.

* Revert "Helium Lib attempt: 2 (#930)"

This reverts commit dfa2c08.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andymck andymck andymck left review comments

@bbalser bbalser bbalser approved these changes

@jeffgrunewald jeffgrunewald jeffgrunewald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaeldjeffrey @andymck @bbalser @jeffgrunewald