-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Packet Verifier Transaction Recovery #958
Open
michaeldjeffrey
wants to merge
13
commits into
main
Choose a base branch
from
mj/mobile-pv-txn-recovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cd9a58
to
acf212a
Compare
macpie
approved these changes
Feb 27, 2025
- burn checks for sufficient balance
acf212a
to
287d583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is step 1 in getting back to using
helium-lib
for solana.It does not currently use
helium-lib
for anything, yet.But adds failure resilience for
mobie-packet-verifier
.All the changes in
iot-packet-verifier
were aimed towards making the integration tests use more production code.The only new change here, is we check if there are any in flight transactions before burning.
There should only ever be 1 for this iteration of the code.
Mobile Packet Verifier
pending_txns
andpending_data_transfer_sessions
.data_transfer_sessions
.IoT Packet Verifier
#[sqlx::test]
to use production code.Solana
TestSolanaClientMap
replacesArc<Mutex<HashMap<PublicKeyBinary, u64>>>
impls