Add dependencies fix paths #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added list of some of the dependencies that are not included on an Ubuntu LTS Server install. The `$path` was incorrect in multiple places in the instructions.
theferrit32
reviewed
Sep 14, 2018
| @@ -21,7 +28,7 @@ Install python 3.5 or greater. This example uses 3.6. | |||
|
|
|||
| ``` | |||
| [auth_microservice] $ git clone https://github.com/heliumdatacommons/auth_microservice.git | |||
| [auth_microservice] $ cd auth_microservice/ | |||
| [auth_microservice] $ cd auth_microservice/src/microservice/ | |||
There was a problem hiding this comment.
@BenjaminHCCarr after the previous PR was merged, please changes instances of src to example and I will merge this one
stdweird
reviewed
Sep 14, 2018
| @@ -1,6 +1,13 @@ | |||
| # auth_microservice | |||
| Microservice which abstracts out OAuth2/OpenID exchanges and token management from applications | |||
|
|
|||
| Requires: | |||
There was a problem hiding this comment.
can you make clear that these are requirements for the example, not for auth_microservice. auth_microservice doesn't need any of these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added list of some of the dependencies that are not included on an Ubuntu LTS Server install.
The
$pathwas incorrect in multiple places in the instructions.