Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape percent character when yanking to search register #12886

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jrvidal
Copy link
Contributor

@jrvidal jrvidal commented Feb 16, 2025

When yanking to the search register with *, percent signs are used verbatim, which messes with the picker column filter.

@pascalkuthe
Copy link
Member

This is not the right behavior outside of global search. For normal search with n, p, / % should not be escaped.

The escaping here only turns the searchterm into a valid regex. I think what we should do is inside global search upon accepting the suggestion escape any percent characters

@jrvidal
Copy link
Contributor Author

jrvidal commented Feb 17, 2025

Good point, I've updated it.

I think it'd be nice that the prompt suggestion also showed the escaped query, but that would need some customization to be added to Prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants