Corrected the test case

cmd/chart-repo/utils.go

@@ -99,8 +99,7 @@ func syncRepo(dbSession datastore.Session, repoName, repoURL string, authorizati
 
 	charts := chartsFromIndex(index, r)
 	if len(charts) == 0 {
-		errors.New("no charts in repository index")
-		return nil
+		return errors.New("no charts in repository index")
 	}
 	err = importCharts(dbSession, charts)
 	if err != nil {

cmd/chart-repo/utils_test.go

@@ -73,24 +73,6 @@ func (h *goodHTTPClient) Do(req *http.Request) (*http.Response, error) {
 	return w.Result(), nil
 }
 
-type chartHTTPClient struct{}
-
-func (h *chartHTTPClient) Do(req *http.Request) (*http.Response, error){
-	w := httptest.NewRecorder()
-	// Don't accept trailing slashes
-	if strings.HasPrefix(req.URL.Path, "//") {
-		w.WriteHeader(500)
-	}
-	// If subpath repo URL test, check that index.yaml is correctly added to the
-	// subpath
-	if req.URL.Host == "subpath.test" && req.URL.Path != "/subpath/index.yaml" {
-		w.WriteHeader(500)
-	}
-
-	w.Write(nil)
-	return w.Result(), nil
-}
-
 type authenticatedHTTPClient struct{}
 
 func (h *authenticatedHTTPClient) Do(req *http.Request) (*http.Response, error) {
@@ -603,7 +585,9 @@ func (h *emptyChartRepoHTTPClient) Do(req *http.Request) (*http.Response, error)
 
 
 func Test_emptyChartRepo(t *testing.T) {
-	netClient = &badHTTPClient{} 
-	_, err := fetchRepoIndex(repo{URL: "https://my.examplerepo.com"})
-	assert.ExistsErr(t, err, "failed request")
+	netClient = &emptyChartRepoHTTPClient{} 
+	m := mock.Mock{}
+	dbSession := mockstore.NewMockSession(&m)
+	err := syncRepo(dbSession, "test", repo{URL: "https://my.examplerepo.com"}, "")
+	assert.ExistsErr(t, err, "Failed Request")
 }