Added check for empty charts in chart-repo (#604)

* Signed-off-by: Himanshu Pandey <[email protected]> Added check for empty charts * Added Test case for Empty Charts Signed-off-by: Himanshu Pandey <[email protected]> * Corrected the test case Signed-off-by: Himanshu Pandey <[email protected]>
helm · Mar 7, 2019 · a5df290 · a5df290
1 parent c2178b1
commit a5df290
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/cmd/chart-repo/testdata/empty-repo-index.yaml b/cmd/chart-repo/testdata/empty-repo-index.yaml
@@ -0,0 +1 @@
+entries:
diff --git a/cmd/chart-repo/utils.go b/cmd/chart-repo/utils.go
@@ -98,6 +98,9 @@ func syncRepo(dbSession datastore.Session, repoName, repoURL string, authorizati
 	}
 
 	charts := chartsFromIndex(index, r)
+	if len(charts) == 0 {
+		return errors.New("no charts in repository index")
+	}
 	err = importCharts(dbSession, charts)
 	if err != nil {
 		return err

diff --git a/cmd/chart-repo/utils_test.go b/cmd/chart-repo/utils_test.go
@@ -570,3 +570,22 @@ h251U/Daz6NiQBM9AxyAw6EHm8XAZBvCuebfzyrT
 		t.Error(err)
 	}
 }
+
+var emptyRepoIndexYAMLBytes, _ = ioutil.ReadFile("testdata/empty-repo-index.yaml")
+var emptyRepoIndexYAML = string(emptyRepoIndexYAMLBytes)
+
+type emptyChartRepoHTTPClient struct{}
+
+func (h *emptyChartRepoHTTPClient) Do(req *http.Request) (*http.Response, error) {
+	w := httptest.NewRecorder()
+	w.Write([]byte(emptyRepoIndexYAML))
+	return w.Result(), nil
+}
+
+func Test_emptyChartRepo(t *testing.T) {
+	netClient = &emptyChartRepoHTTPClient{}
+	m := mock.Mock{}
+	dbSession := mockstore.NewMockSession(&m)
+	err := syncRepo(dbSession, "testRepo", "https://my.examplerepo.com", "")
+	assert.ExistsErr(t, err, "Failed Request")
+}