Added Test case for Empty Charts

Signed-off-by: Himanshu Pandey <[email protected]>

cmd/chart-repo/testdata/empty-repo-index.yaml

@@ -0,0 +1 @@
+entries:

cmd/chart-repo/utils.go

@@ -99,7 +99,7 @@ func syncRepo(dbSession datastore.Session, repoName, repoURL string, authorizati
 
 	charts := chartsFromIndex(index, r)
 	if len(charts) == 0 {
-		log.Fatal("No charts are found")
+		errors.New("no charts in repository index")
 		return nil
 	}
 	err = importCharts(dbSession, charts)

cmd/chart-repo/utils_test.go

@@ -73,6 +73,24 @@ func (h *goodHTTPClient) Do(req *http.Request) (*http.Response, error) {
 	return w.Result(), nil
 }
 
+type chartHTTPClient struct{}
+
+func (h *chartHTTPClient) Do(req *http.Request) (*http.Response, error){
+	w := httptest.NewRecorder()
+	// Don't accept trailing slashes
+	if strings.HasPrefix(req.URL.Path, "//") {
+		w.WriteHeader(500)
+	}
+	// If subpath repo URL test, check that index.yaml is correctly added to the
+	// subpath
+	if req.URL.Host == "subpath.test" && req.URL.Path != "/subpath/index.yaml" {
+		w.WriteHeader(500)
+	}
+
+	w.Write(nil)
+	return w.Result(), nil
+}
+
 type authenticatedHTTPClient struct{}
 
 func (h *authenticatedHTTPClient) Do(req *http.Request) (*http.Response, error) {
@@ -570,3 +588,26 @@ h251U/Daz6NiQBM9AxyAw6EHm8XAZBvCuebfzyrT
 		t.Error(err)
 	}
 }
+
+var emptyRepoIndexYAMLBytes, _ = ioutil.ReadFile("testdata/empty-repo-index.yaml")
+var emptyRepoIndexYAML = string(emptyRepoIndexYAMLBytes)
+
+type chartHTTPClient struct{}
+
+
+func (h *emptyChartRepoHTTPClient) Do(req *http.Request) (*http.Response, error){
+	w := httptest.NewRecorder()
+	// Don't accept trailing slashes
+	if strings.HasPrefix(req.URL.Path) {
+		w.WriteHeader(500)
+	}
+	w.Write([]byte(emptyRepoIndexYAML))
+	return w.Result(), nil
+}  
+
+
+func Test_syncURLInvalidity(t *testing.T) {
+	netClient = &badHTTPClient{} 
+	_, err := fetchRepoIndex(repo{URL: "https://my.examplerepo.com"})
+	assert.ExistsErr(t, err, "failed request")
+}