feat: impl patch with alpha plugin flag. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @yxxhero PTAL. |
Peefy
force-pushed
the
feat-chartify-kustomize-patch-plugin-flag
branch
from
e0841b0
to
4547d55
Compare
yxxhero
reviewed
Aug 1, 2023
Peefy
force-pushed
the
feat-chartify-kustomize-patch-plugin-flag
branch
from
4547d55
to
2cef52c
Compare
|
@Peefy please fix the ci error. then I will merge this PR. |
Signed-off-by: peefy <[email protected]>
Peefy
force-pushed
the
feat-chartify-kustomize-patch-plugin-flag
branch
from
2cef52c
to
feef492
Compare
Signed-off-by: peefy <[email protected]>
yxxhero
pushed a commit
that referenced
this pull request
Sep 19, 2023
* feat: impl patch with alpha plugin flag Signed-off-by: peefy <[email protected]> * refactor: kustomize build arguments and remove duplicate code Signed-off-by: peefy <[email protected]> --------- Signed-off-by: peefy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
feat: impl patch with alpha plugin flag. More information is here: helmfile/helmfile#827
I found that the helmfile HelmState structure passed
chartifyOpts.EnableKustomizeAlphaPlugins=truetochartify, but it did not take effect inchartify.Tests
For transformer and alpha plugin, I have added a integration test using the
AnnotationsTransformerkustomize plugin