refactor: prepare ExternalContent to use filters on SourceReaders

[thorbrink]

This pull request includes several changes to improve the composer.json file, refactor the App.php file, and update test files. The changes focus on adding new dependencies, cleaning up unused imports, improving the setup of external content, and replacing mock objects in tests.

Improvements to composer.json:

• Added new script unused to check for unused classes using class-leak and added dependencies dg/bypass-finals and tomasvotruba/class-leak. [1] [2]

Refactoring in App.php:

• Removed unused imports and added new necessary imports in library/App.php. [1] [2]
• Refactored setupExternalContent method to use addHooks method instead of register method for better readability and maintainability. [1] [2]

Updates to test files:

• Replaced WpMockFactory::createWpCommentQuery with WP_Comment_Query in OptionalHideDiscussionWhenLoggedOut.test.php. [1] [2] [3] [4]
• Replaced WpMockFactory::createWpdb with wpdb in Customizer.test.php. [1] [2]

Removal of unused class:

• Removed the PopulateTaxonomySchemaPropertyFieldOptions class from library/ExternalContent/AcfFieldContentModifiers/.

Enhancements in SourceConfig:

• Added FilterDefinition to the SourceConfig class and updated the constructor and methods accordingly. [1] [2] [3] [4]
• Updated SourceConfigFactory to create SourceConfig instances with FilterDefinition. [1] [2]

[sonarqubecloud]

Quality Gate failed

Failed conditions
2 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE