Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPlot compatibility #153

Merged
merged 8 commits into from
Sep 21, 2023
Merged

PyPlot compatibility #153

merged 8 commits into from
Sep 21, 2023

Conversation

henry2004y
Copy link
Owner

@henry2004y henry2004y commented Sep 21, 2023

  • Test the compatibility of VlasiatorPyPlot with MakieVlasiatorExt for Julia 1.9+
  • Fix Matplotlib 3.8 compatibility issues

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15% ⚠️

Comparison is base (4b30174) 87.87% compared to head (a1c356d) 87.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   87.87%   87.73%   -0.15%     
==========================================
  Files          15       15              
  Lines        2441     2445       +4     
==========================================
  Hits         2145     2145              
- Misses        296      300       +4     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Repository owner deleted a comment from github-actions bot Sep 21, 2023
Repository owner deleted a comment from github-actions bot Sep 21, 2023
Repository owner deleted a comment from github-actions bot Sep 21, 2023
Repository owner deleted a comment from github-actions bot Sep 21, 2023
@henry2004y henry2004y changed the title PyPlot extension PyPlot compatible with MakieVlasiatorExt and Matplotlib 3.8 Sep 21, 2023
Repository owner deleted a comment from github-actions bot Sep 21, 2023
Repository owner deleted a comment from github-actions bot Sep 21, 2023
@henry2004y henry2004y changed the title PyPlot compatible with MakieVlasiatorExt and Matplotlib 3.8 PyPlot compatibility Sep 21, 2023
@github-actions
Copy link

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Vlasiator.jl/Vlasiator.jl

Job Properties

  • Time of benchmarks:
    • Target: 21 Sep 2023 - 16:03
    • Baseline: 21 Sep 2023 - 16:05
  • Package commits:
    • Target: c4d712
    • Baseline: 4b3017
  • Julia commits:
    • Target: bed2cd
    • Baseline: bed2cd
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["VTK", "AMR_maxonly"] 0.94 (5%) ✅ 1.00 (1%)
["read", "DCCRG_derived"] 0.94 (5%) ✅ 1.00 (1%)
["read", "DCCRG_vector"] 0.88 (5%) ✅ 1.00 (1%)
["read", "FG"] 0.79 (5%) ✅ 1.00 (1%)
["read", "VDF"] 1.05 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["VTK"]
  • ["read"]

Julia versioninfo

Target

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1011-azure #11~22.04.1-Ubuntu SMP Wed Aug 23 19:26:19 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       1278 s          0 s        260 s       1447 s          0 s
       #2  2095 MHz       1285 s          0 s        236 s       1439 s          0 s
  Memory: 6.759754180908203 GB (5271.3046875 MB free)
  Uptime: 306.86 sec
  Load Avg:  1.09  0.92  0.44
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1011-azure #11~22.04.1-Ubuntu SMP Wed Aug 23 19:26:19 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       1294 s          0 s        280 s       2540 s          0 s
       #2  2095 MHz       2225 s          0 s        432 s       1443 s          0 s
  Memory: 6.759754180908203 GB (5191.140625 MB free)
  Uptime: 420.82 sec
  Load Avg:  1.03  0.96  0.51
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/Vlasiator.jl/Vlasiator.jl

Job Properties

  • Time of benchmark: 21 Sep 2023 - 16:3
  • Package commit: c4d712
  • Julia commit: bed2cd
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["VTK", "AMR_full"] 556.916 μs (5%) 649.52 KiB (1%) 202
["VTK", "AMR_maxonly"] 460.713 μs (5%) 611.42 KiB (1%) 170
["read", "DCCRG_derived"] 375.311 μs (5%) 912.88 KiB (1%) 45
["read", "DCCRG_scalar"] 22.001 μs (5%) 123.39 KiB (1%) 12
["read", "DCCRG_select_large"] 52.602 μs (5%) 39.16 KiB (1%) 13
["read", "DCCRG_select_small"] 8.367 μs (5%) 480 bytes (1%) 11
["read", "DCCRG_vector"] 64.202 μs (5%) 369.52 KiB (1%) 12
["read", "FG"] 120.704 μs (5%) 231.27 KiB (1%) 149
["read", "VDF"] 142.004 μs (5%) 504.47 KiB (1%) 13
["read", "meta"] 803.623 μs (5%) 596.59 KiB (1%) 3464

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["VTK"]
  • ["read"]

Julia versioninfo

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1011-azure #11~22.04.1-Ubuntu SMP Wed Aug 23 19:26:19 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       1278 s          0 s        260 s       1447 s          0 s
       #2  2095 MHz       1285 s          0 s        236 s       1439 s          0 s
  Memory: 6.759754180908203 GB (5271.3046875 MB free)
  Uptime: 306.86 sec
  Load Avg:  1.09  0.92  0.44
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Vlasiator.jl/Vlasiator.jl

Job Properties

  • Time of benchmark: 21 Sep 2023 - 16:5
  • Package commit: 4b3017
  • Julia commit: bed2cd
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["VTK", "AMR_full"] 582.417 μs (5%) 649.52 KiB (1%) 202
["VTK", "AMR_maxonly"] 490.116 μs (5%) 611.42 KiB (1%) 170
["read", "DCCRG_derived"] 399.913 μs (5%) 912.88 KiB (1%) 45
["read", "DCCRG_scalar"] 22.200 μs (5%) 123.39 KiB (1%) 12
["read", "DCCRG_select_large"] 54.302 μs (5%) 39.16 KiB (1%) 13
["read", "DCCRG_select_small"] 8.434 μs (5%) 480 bytes (1%) 11
["read", "DCCRG_vector"] 72.603 μs (5%) 369.52 KiB (1%) 12
["read", "FG"] 153.105 μs (5%) 231.27 KiB (1%) 149
["read", "VDF"] 135.016 μs (5%) 504.47 KiB (1%) 13
["read", "meta"] 797.326 μs (5%) 596.59 KiB (1%) 3464

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["VTK"]
  • ["read"]

Julia versioninfo

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1011-azure #11~22.04.1-Ubuntu SMP Wed Aug 23 19:26:19 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       1294 s          0 s        280 s       2540 s          0 s
       #2  2095 MHz       2225 s          0 s        432 s       1443 s          0 s
  Memory: 6.759754180908203 GB (5191.140625 MB free)
  Uptime: 420.82 sec
  Load Avg:  1.03  0.96  0.51
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      46 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             2
On-line CPU(s) list:                0,1
Vendor ID:                          GenuineIntel
Model name:                         Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
CPU family:                         6
Model:                              85
Thread(s) per core:                 1
Core(s) per socket:                 2
Socket(s):                          1
Stepping:                           4
BogoMIPS:                           4190.15
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor:                  Microsoft
Virtualization type:                full
L1d cache:                          64 KiB (2 instances)
L1i cache:                          64 KiB (2 instances)
L2 cache:                           2 MiB (2 instances)
L3 cache:                           35.8 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0,1
Vulnerability Gather data sampling: Unknown: Dependent on hypervisor status
Vulnerability Itlb multihit:        KVM: Mitigation: VMX unsupported
Vulnerability L1tf:                 Mitigation; PTE Inversion
Vulnerability Mds:                  Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:             Mitigation; PTI
Vulnerability Mmio stale data:      Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:             Vulnerable
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Mitigation; Clear CPU buffers; SMT Host state unknown
Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@henry2004y henry2004y marked this pull request as ready for review September 21, 2023 16:06
@henry2004y henry2004y merged commit 3b5a9cf into master Sep 21, 2023
6 of 7 checks passed
@henry2004y henry2004y deleted the pyplot_ext branch September 21, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant