Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go mod support #43

Closed
wants to merge 1 commit into from
Closed

go mod support #43

wants to merge 1 commit into from

Conversation

exfly
Copy link

@exfly exfly commented Jun 9, 2019 •
edited
Loading

close issues: #42

@exfly
Copy link
Author

exfly commented Jun 9, 2019

本地已经可以很好的工作。有点新的东西需要重新讨论一下。是否需要makefile来做傻瓜的自动化呢？暂时感觉项目比较少，加makefile会显得比较笨重？如果感觉需要一个makefile的话，可以下边评论，如果不需要的话，现在这个样子已经可以使用了。改了一下travis-ci.yaml，support go mod or not， ci can also pass

@sndnvaps
Copy link
Contributor

我的想法是，暂时不加go mod支持，好像没有什么大的作用。。
加makefile也不起大作用，因为现在的代码量也不是很大。。

@henson
Copy link
Owner

henson commented Jun 16, 2019

感谢您的提交，个人认为没必要加go mod

@henson henson closed this Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exfly @sndnvaps @henson