Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the egg-herbie interface a bit #1134

Merged
merged 13 commits into from
Jan 22, 2025
Merged

Conversation

pavpanchekha
Copy link
Contributor

@pavpanchekha pavpanchekha commented Jan 21, 2025

In this PR make-egg-runner becomes make-egraph and run-egg becomes four functions, egraph-equal?, egraph-prove, egraph-best, and egraph-variations. This allows me to simplify preprocessing somewhat, analogous to the recent simplification of derivations.

I also leverage that fact that egg->herbie-dict and herbie->egg-dict are only used to rename variables, which means we don't need the dictionaries at all, just a normal Herbie context. One less thing to think about.

@pavpanchekha pavpanchekha merged commit eaccd25 into main Jan 22, 2025
6 checks passed
@pavpanchekha pavpanchekha deleted the refactor-egg-herbie branch January 22, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant