Refactor the egg-herbie
interface a bit
#1134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
make-egg-runner
becomesmake-egraph
andrun-egg
becomes four functions,egraph-equal?
,egraph-prove
,egraph-best
, andegraph-variations
. This allows me to simplifypreprocessing
somewhat, analogous to the recent simplification ofderivations
.I also leverage that fact that
egg->herbie-dict
andherbie->egg-dict
are only used to rename variables, which means we don't need the dictionaries at all, just a normal Herbie context. One less thing to think about.