Bump enode count to 20k #1137
Closed
Bump enode count to 20k #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't do anything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR looking to see if it's possible to bump the number of enodes in our egraphs to 20k and, in doing so, maybe allow
no-localizeto merge. It's not really clear why we need to bump the number of enodes, butno-localizeis such a big speedup that maybe this would still be a pareto improvement? Right now, bumping enode count carries a huge cost because our very slow extraction procedure then needs to extract from this bigger egraph, but in the long term, maybe the new encoding can fix that.