Dump Rival commands from Herbie #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also @AYadrov right now the Rival REPL doesn't support hints. Maybe there's a way to add support? If we did then we could add the hints to the dump. |
|
Yes, that would be good and interesting to implement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
dump:rivalHerbie flag (analogous to the existingdump:rivalflag) that dumps every Rival machine to its own file, in Rival format, with every invocation. This might contribute to efforts to make Rival a standalone program.I've taken some care to ensure that it's exactly the same inputs, which is a little annoying to read since it means we have to convert all inputs to rationals. @AYadrov possibly this can replace the existing giant JSON file we use in the Rival nightly.