Automated Resyntax fixes #1147
Closed
Automated Resyntax fixes #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Instead of using `(apply append ...)` to flatten a list of lists, consider using `for*/list` to flatten the list.
The `define` form supports a shorthand for defining functions.
This negated `when` expression can be replaced by an `unless` expression.
This `if` expression can be refactored to an equivalent expression using `and`.
pavpanchekha
requested changes
Feb 2, 2025
| (for/list ([impl (in-list impls)]) | ||
| `(,@(impl-info impl 'itype) ,(impl-info impl 'otype)))))) | ||
| (remove-duplicates (for*/list ([impl (in-list impls)] | ||
| [v (in-list `(,@(impl-info impl 'itype) ,(impl-info impl |
There was a problem hiding this comment.
Again, @jackfirth , this doesn't feel like an improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 10 issues in 3 files.
inverted-whenlet-to-defineapply-append-for-loop-to-for-loopdefine-lambda-to-defineif-else-false-to-and