Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change execution order for single-threaded server #1149

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pavpanchekha
Copy link
Contributor

Right now, the single-threaded server runs jobs when start-job is called. This PR changes it to instead run jobs when wait-for-job is called. The reason to change things is simple; run.rkt has code that at a high level does:

(for ([job ...])
  (start-job job))
(for ([job ...])
  (wait-for-job job)
  (print-status job))

If we run things in start-job then we get all the status prints at the very end, once all jobs are done (useless). If we run then in wait-for-job then we get prints one at a time, like we're suppose to.

The PR also has some random minor improvements to the server code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant