-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Resyntax fixes #1153
Automated Resyntax fixes #1153
Conversation
This quasiquotation is equialent to calling `append`.
The `append` function does nothing when applied to only one list.
Using `cond` instead of `if` here makes `begin` unnecessary
@@ -281,7 +281,7 @@ | |||
(list (header #"X-Job-Count" (string->bytes/utf-8 (~a (job-count)))) | |||
(header #"X-Herbie-Job-ID" (string->bytes/utf-8 job-id)) | |||
(header #"Access-Control-Allow-Origin" (string->bytes/utf-8 "*"))) | |||
(λ (out) `()))] | |||
(λ (out) (append)))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look ideal @jackfirth
@@ -281,7 +281,7 @@ | |||
(list (header #"X-Job-Count" (string->bytes/utf-8 (~a (job-count)))) | |||
(header #"X-Herbie-Job-ID" (string->bytes/utf-8 job-id)) | |||
(header #"Access-Control-Allow-Origin" (string->bytes/utf-8 "*"))) | |||
(λ (out) `()))] | |||
(λ (out) (append)))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(λ (out) (append)))] | |
void)] |
@@ -396,7 +396,7 @@ | |||
(list (header #"X-Job-Count" (string->bytes/utf-8 (~a (job-count)))) | |||
(header #"X-Herbie-Job-ID" (string->bytes/utf-8 job-id)) | |||
(header #"Access-Control-Allow-Origin" (string->bytes/utf-8 "*"))) | |||
(λ (out) `()))] | |||
(λ (out) (append)))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(λ (out) (append)))] | |
void)] |
Resyntax fixed 5 issues in 3 files.
append-single-list-to-single-list
quasiquote-to-append
if-begin-to-cond