Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Resyntax fixes #1153

Closed
wants to merge 3 commits into from
Closed

Automated Resyntax fixes #1153

wants to merge 3 commits into from

Conversation

resyntax-ci[bot]
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Feb 23, 2025

Resyntax fixed 5 issues in 3 files.

  • Fixed 2 occurrences of append-single-list-to-single-list
  • Fixed 2 occurrences of quasiquote-to-append
  • Fixed 1 occurrence of if-begin-to-cond

This quasiquotation is equialent to calling `append`.
The `append` function does nothing when applied to only one list.
Using `cond` instead of `if` here makes `begin` unnecessary
@@ -281,7 +281,7 @@
(list (header #"X-Job-Count" (string->bytes/utf-8 (~a (job-count))))
(header #"X-Herbie-Job-ID" (string->bytes/utf-8 job-id))
(header #"Access-Control-Allow-Origin" (string->bytes/utf-8 "*")))
(λ (out) `()))]
(λ (out) (append)))]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look ideal @jackfirth

@@ -281,7 +281,7 @@
(list (header #"X-Job-Count" (string->bytes/utf-8 (~a (job-count))))
(header #"X-Herbie-Job-ID" (string->bytes/utf-8 job-id))
(header #"Access-Control-Allow-Origin" (string->bytes/utf-8 "*")))
(λ (out) `()))]
(λ (out) (append)))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(λ (out) (append)))]
void)]

@@ -396,7 +396,7 @@
(list (header #"X-Job-Count" (string->bytes/utf-8 (~a (job-count))))
(header #"X-Herbie-Job-ID" (string->bytes/utf-8 job-id))
(header #"Access-Control-Allow-Origin" (string->bytes/utf-8 "*")))
(λ (out) `()))]
(λ (out) (append)))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(λ (out) (append)))]
void)]

@pavpanchekha pavpanchekha deleted the autofix-17-1 branch February 25, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants