package-sets: init #945
package-sets: init #945
Conversation
ConnorBaker
force-pushed
the
feat/package-sets
branch
from
4dad44b
to
c0d5eb5
Compare
ConnorBaker
force-pushed
the
feat/package-sets
branch
from
c0d5eb5
to
2cd99df
Compare
|
|
||
| [package-sets](https://github.com/ConnorBaker/package-sets) was born out of frustration with the manual | ||
| process of adding packages and overlays to a flake. If your flakes have more than a few packages, | ||
| dependencies between packages, or require Nixpkgs use a non-standard configuration, this module is for you. |
There was a problem hiding this comment.
I haven't had much trouble making dependencies through config.packages.<name> in perSystem. How could it help me?
There was a problem hiding this comment.
The above sentences are mostly equivalent, and maybe you could rephrase them to be less subjective and more factual?
I think it's helpful to think of the module as a function. You've already mentioned what are the outputs, but what are the inputs, roughly? That would make it easier to decide for readers whether this could be the right functionality they need.
Also helpful would be a short example that makes your concepts more tangible and lets you explain in concrete terms what the flake outputs etc will be.
|
|
||
| ## Limitations | ||
|
|
||
| A great deal of this module's functionality is based on `lib.packagesFromDirectoryRecursive`. |
There was a problem hiding this comment.
Couldn't you pass the output of packagesFromDirectoryRecursive as an option default?
| ## Limitations | ||
|
|
||
| A great deal of this module's functionality is based on `lib.packagesFromDirectoryRecursive`. | ||
| Unfortunately, [`flake.packages`](../options/flake-parts.html#opt-flake.packages) does not allow nested |
There was a problem hiding this comment.
| Unfortunately, [`flake.packages`](../options/flake-parts.html#opt-flake.packages) does not allow nested | |
| Unfortunately, [the `packages` flake output](../options/flake-parts.html#opt-flake.packages) does not allow nested |
I'll also update the option's description to say that it's not a limitation of flake-parts but of the flake format.
|
Looks like there's a broken link in the new docs: https://hercules-ci.com/accounts/github/hercules-ci/derivations/%2Fnix%2Fstore%2Fm2n50py62g0j2bkz98k1gaiypg0762iy-linkcheck.drv/log?via-job=84085f85-c558-421f-b1ed-3b69bc35572a |
|
nitpick: |
package-setsis the module I didn't realize I needed; one I've been inadvertently re-creating every time I start a new project using flakes and end up with more than one package.The README is sparse, but the documentation for the module should be extensive.
I look forward to hearing your thoughts!