Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional keyword support in openvpn lens #221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamesjuran
Copy link

Support the following keywords:

up
plugin
ping
ping-restart
ping-timer-rem

Also adds authentication support to http-proxy keyword.

New
---
up
plugin
ping
ping-restart
ping-timer-rem

http-proxy now also supports authentication.
@lutter
Copy link
Member

lutter commented Apr 3, 2015

Thanks for the patch. Could you add some tests in lenses/tests/test_openvpn.aug that check that these directives are processed as expected ?

@raphink
Copy link
Member

raphink commented Jun 12, 2015

@jamesjuran any news on the tests for this?

@jamesjuran
Copy link
Author

I'd like to, but it will probably be a while before I have time to do this, and my immediate problem is solved. If someone else would like to do the tests to help get this committed, please go ahead.

@raphink
Copy link
Member

raphink commented Feb 25, 2019

@jamesjuran are you still interested in finishing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants