-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc support of lambda parameters and return value for cpp,swift,dart #1545
Changes from 2 commits
728b5d8
349cdee
dd15abe
64d7aac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,23 +18,8 @@ | |
! License-Filename: LICENSE | ||
! | ||
!}} | ||
{{#resolveName comment}}{{#unless this.isEmpty}}{{prefix this "/// "}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have to split this the doc part and attribute part. Otherwise, the lambda gets some duplicated attributes here |
||
///{{/unless}}{{/resolveName}}{{!! | ||
}}{{#parameters}}{{#set self=this}}{{#resolveName comment}}{{#unless this.isEmpty}} | ||
/// [{{resolveName self}}] {{prefix this "/// " skipFirstLine=true}} | ||
///{{/unless}}{{/resolveName}}{{/set}}{{/parameters}}{{!! | ||
}}{{#resolveName returnType.comment}}{{#unless this.isEmpty}} | ||
/// Returns [{{resolveName returnType.typeRef}}]. {{prefix this "/// " skipFirstLine=true}} | ||
///{{/unless}}{{/resolveName}}{{!! | ||
}}{{#if thrownType}}{{#resolveName thrownType.comment}}{{#unless this.isEmpty}} | ||
/// Throws [{{resolveName exception}}]. {{prefix this "/// " skipFirstLine=true}} | ||
///{{/unless}}{{/resolveName}}{{/if}}{{!! | ||
}}{{#ifPredicate "needsNoDoc"}} | ||
/// @nodoc{{/ifPredicate}}{{!! | ||
}}{{#if attributes.deprecated}} | ||
@Deprecated("{{#resolveName attributes.deprecated.message}}{{escape this}}{{/resolveName}}") | ||
{{/if}}{{!! | ||
}}{{#if attributes.dart.attribute}} | ||
{{>dart/DartLambdaDocs}} | ||
{{#if attributes.dart.attribute}} | ||
|
||
{{#attributes.dart.attribute}} | ||
@{{this}}{{#if iter.hasNext}} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,9 @@ | |
! License-Filename: LICENSE | ||
! | ||
!}} | ||
{{>dart/DartDocumentation}}{{>dart/DartAttributes}} | ||
{{>dart/DartLambdaDocs}} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have to leave a blank line here. Otherwise, the lambda declaration will be in the same line as the empty comment, which would hide the lambda declaration. |
||
{{>dart/DartAttributes}} | ||
typedef {{resolveName}} = {{>dart/DartLambdaType}}; | ||
|
||
// {{resolveName}} "private" section, not exported. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,11 @@ class _GLUECODIUM_CPP_EXPORT ExcludedCommentsOnly { | |
USELESS | ||
}; | ||
/** | ||
* | ||
* \private | ||
* \param[in] ::std::string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one lost the const&. Would need some fix. |
||
* \param[in] int32_t | ||
* \return | ||
*/ | ||
using SomeLambda = ::std::function<double(const ::std::string&, const int32_t)>; | ||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this addition, it would go to the throw statement.