C++: add missing export macro to 'CppEnumeration.mustache' #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated files for C++ did not contain export macro
for enumerations. That was not the case of structs and
classes. The reason for that was missing inclusion of
'CppExportMacro' in 'CppEnumeration.mustache'.
Note: the change in logic is only a single line.
The remaining changes in the commit are related
to smoke tests -- the expected generated files
with enumerations have been adjusted.
Signed-off-by: Patryk Wrobel <[email protected]>
pwrobeldev
force-pushed
the
pwrobeldev/add-missing-export-macro-in-cpp-enumeration-mustache
branch
from
b89cf25
to
fb2fc62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated files for C++ did not contain export macro for enumerations.
That was not the case of structs and classes. The reason for that was
missing inclusion of 'CppExportMacro' in 'CppEnumeration.mustache'.
Note: the change in logic is only a single line.
The remaining changes in the commit are related
to smoke tests -- the expected generated files
with enumerations have been adjusted.