Don't return null for non-nullable Blobs in Java #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated JNI conversion function for non-nullable Blobs to avoid returning `null` when the C++ function returns a null shared pointer. Having a null shared pointer coming from C++ when the type is specified as non-nullable in the IDL is a violation of contract. The correct fix for this issue would be to change `Blob` representation from `shared_ptr<vector>` to something that cannot be `null`. However, this would be a breaking change, so it has to be done later (#934). For now it's just the small JNI workaround. Resolves: #929 Signed-off-by: Daniel Kamkha <[email protected]>
Hsilgos
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated JNI conversion function for non-nullable Blobs to avoid returning
nullwhen the C++ function returns a nullshared pointer.
Having a null shared pointer coming from C++ when the type is specified as non-nullable in the IDL is a violation of
contract. The correct fix for this issue would be to change
Blobrepresentation fromshared_ptr<vector>to somethingthat cannot be
null. However, this would be a breaking change, so it has to be done later (#934). For now it's justthe small JNI workaround.
Resolves: #929
Signed-off-by: Daniel Kamkha [email protected]