Nakama Console was missing js-yaml in package.json #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toqueteos
changed the title
|
Morning @sesposito 👋 Could you please retrigger CI now that #1261 was merged? |
toqueteos
force-pushed
the
missing-console-dependency
branch
from
fbb089e
to
a985acb
Compare
|
My bad, I had to rebase with latest master. Otherwise the workflow file changes are not there. Oops 😓 |
sesposito
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1261 for "Run tests" action to actually run.
Spotted this while messing around with the console codebase.
It's used here:
https://github.com/heroiclabs/nakama/blob/master/console/ui/src/app/config/config.component.ts#L19