Stop publishing to heroku/heroku-private on Docker Hub
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base images are currently double-published to Docker Hub - once to the public `heroku/heroku` repository, and then again to the private `heroku/heroku-private` repo. Publishing to `heroku/heroku-private` was added in: #130 ...with the explanation that it might help internally with rollback use-cases. However: 1. We've never had cause to use this private repository for rollback in the 5 years since. 2. We have a robust image rollout and rollback process, which doesn't use these images, but instead Cheverny (for the S3 image releases) and image tags on the `heroku/heroku` repo for the Docker image side: https://github.com/heroku/cheverny/blob/main/docs/base-image-release.md#rollback-process 3. The author of the PR that added the publishing of these images has confirmed that there isn't some other reason for keeping them: https://salesforce-internal.slack.com/archives/C01068P24S3/p1707346168976339 As such, we can stop publishing to this repository to simplify the publishing process (which is going to be getting a lot more complex for multi-arch support soon). GUS-W-15018626.
Malax
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base images are currently double-published to Docker Hub - once to the public
heroku/herokurepository, and then again to the privateheroku/heroku-privaterepo.Publishing to
heroku/heroku-privatewas added in:#130
...with the explanation that it might help internally with rollback use-cases.
However:
heroku/herokurepo for the Docker image side: https://github.com/heroku/cheverny/blob/main/docs/base-image-release.md#rollback-processAs such, we can stop publishing to this repository to simplify the publishing process (which is going to be getting a lot more complex for multi-arch support soon).
GUS-W-15018626.