Heroku-24: Remove git from the run image #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since:
- Most Git use-cases are for cloning dependencies during the build.
- On Heroku at runtime there is no `.git/` metadata to query the
local project's repo anyway (since the directory isn't preserved
during the build).
- It saves 17 MB, and in a CNB world image size is a much bigger
concern, so we need to be more selective about what packages
we include.
- Once Heroku-24 GAs we can't remove packages (since it will break
backwards compatibility given stack rebasing), however, we can add
packages - so we should err on the side of removing packages now.
Before:
```
-----> Size breakdown...
heroku/heroku:24 458MB
heroku/heroku:24-build 1.13GB
```
After:
```
-----> Size breakdown...
heroku/heroku:24 441MB
heroku/heroku:24-build 1.13GB
```
Towards #266.
GUS-W-15159536.
edmorley
force-pushed
the
edmorley/h24-git-build-only
branch
from
e5b3c4d
to
75c7948
Compare
runesoerensen
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is stacked on top of #273.)
Since:
.git/metadata to query the local project's repo anyway (since the directory isn't preserved during the build).Before (once #273 merges):
After:
Towards #266.
GUS-W-15159536.