-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use global print output #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but can you explain the rationale behind switching from stdout
to stderr
again? What's the benefit there?
Sure. Here's an internal link https://salesforce-internal.slack.com/archives/C02GZCPPV38/p1738340566002289. For everyone else, as an oversimplification: Stdout is for machines, stderr is for humans. Here's some more info https://unix.stackexchange.com/questions/331611/do-progress-reports-logging-information-belong-on-stderr-or-stdout. As a related sidebar: I'm wanting to propose that
|
This preserves newlines between when the printer is dropped and then recovered.
Stdout -> Stderr
4871b3f
to
54a3165
Compare
Switches from stdout to the global writer which defaults to stderr. This swich guarantees consistent print output when the print stream is dropped and then we have to construct a new one to emit an error message.