Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(W-17544077): SSH key install via SSH happy path in docs didn't work #3210

Merged
merged 2 commits into from
Feb 11, 2025
Merged

fix(W-17544077): SSH key install via SSH happy path in docs didn't work #3210

merged 2 commits into from
Feb 11, 2025

Conversation

justinwilaby
Copy link
Contributor

This PR corrects the behavior of the keys:add command to match the devcenter docs while maintaining full functionality.

Testing

  1. Rename or generate a key in ~/.ssh that is not the default name of id_rsa.pub
  2. run bin/run keys:add
  3. OBSERVE The behavior in the devcenter docs is seen
  4. Optionally Test other flows like one key with the default name of id_rsa.pub and multiple keys, etc.

@justinwilaby justinwilaby requested a review from a team as a code owner February 7, 2025 13:43
sbosio
sbosio approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Tested the different scenarios and they work as expected now.

@justinwilaby justinwilaby merged commit 5ad2958 into main Feb 11, 2025
8 checks passed
@justinwilaby justinwilaby deleted the jw/keys-add branch February 11, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbosio sbosio sbosio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinwilaby @sbosio