fix(W-17545010): Error when trying to clone a redis instance #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinwilaby
force-pushed
the
jw/fix/W-17545010
branch
from
fc8b0d5 to
1f7ed71
Compare
justinwilaby
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
justinwilaby
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
justinwilaby
force-pushed
the
jw/fix/W-17545010
branch
from
1f7ed71 to
c504439
Compare
justinwilaby
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
justinwilaby
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeError that occurred because no checks were made to inspect the error object before accessing it's properties.
To Test:
View Repro steps in the GUS ticked. Note these repo steps no longer yield the TypeError mentioned.