Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(W-17752806): Pipeline creation must support the generation property #3221

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Feb 18, 2025

Adds the --generation flag to the command.

To Test

  1. Test per usual but use the --generation flag. Try good and bad values, try 'fir' on cedar apps and 'cedar' on fir apps, etc..
    W-17752806

@justinwilaby justinwilaby marked this pull request as ready for review February 18, 2025 16:08
@justinwilaby justinwilaby requested a review from a team as a code owner February 18, 2025 16:08
Copy link
Contributor

@eablack eablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few issues here:

  1. Happy path doesn't work. When I run the command, I get what appears to be a 500 error:
Screenshot 2025-02-18 at 12 31 10 PM
  1. I think we should reconsider how this behaves, maybe talk with @dsouza-anush about it. Right now, the pipelines create command requires an --app flag. Adding the --generation flag means someone can try to create a fir pipeline with a cedar app. The api blocks this, thankfully, but we should stop this from happening earlier. My recommendation is we do one of two things:
  • Keep --app as a required flag and just pass the generation of that app when we do the API call to create a pipeline. If we do this, we do not need to offer generation as a flag option. I think this is the simplest solution.
  • Make '--app' an optional flag and add --generation as a flag and let the user possibly create a pipeline without an app. We probably should check to make sure in the CLI that there isn't a conflict between the --generation value and the app's generation if the user does provide an app.

@justinwilaby
Copy link
Contributor Author

I am working with @bchen528 on this 500 error. It does seem to be a backend issue related to this line.

Originally, I thought this was because the fir app I was using to test was deployed using the BuildService and not git push heroku main.

I'm not really sure why this flag is necessary. The call succeeds and the pipeline API correctly infers the generation without this flag present. There are almost no details in the ticket on this so my assumption was this flag would allow both fir and cedar apps on the same pipeline potentially for migration from cedar to fir on the same pipeline.

@justinwilaby
Copy link
Contributor Author

Moving this to draft until then.

@justinwilaby justinwilaby marked this pull request as draft February 19, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants