Support wwwauth[] key in git credential helper #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers using Heroku-24 and
GO_GIT_CRED_*are seeing errors in their build logs like these:The
wwwauth[]key/value pair is a new addition to the git credential API here: git/git@5f2117b. It was included in git versions 2.41.0 and later. Heroku-22 and prior didn't have this issue, since it uses git 2.34.1. Heroku-24 is using git 2.43.0, so the issue manifests there.The key and values are informational only according to this: https://github.com/git/git/blob/master/Documentation/git-credential.txt#L241-L250.
This PR adds a condition to ignore
wwwauth[].