fix(W-17812967): Heroku-cli-command: Header overflow #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the accumulation of requestIds in the header causing a header overflow error in long running poll operations. These have been observed to be larger than 8k (Node default max) in commands such as pg:wait
This PR limits the
Request-Id
header size to 7k which allows 1k for other header data. If the 7k limit is exceeded, theRequest-Id
is stripped of all previous values and is started over.Note that a side effect of this is that long running poll operations now have the potential of fracturing the API call 'story' in tracking data.
test
npm run build && npm pack
)break
statement in packages/cli/src/commands/ps/wait.ts