Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress): incorrect size in indeterminate storybook #4967

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Mar 2, 2025

Closes #4966

📝 Description

in indeterminate storybook, xs is specified but it's not a correct option.

⛳️ Current behavior (updates)

🚀 New behavior

image

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Style
    • The indeterminate progress indicator has been updated to a medium size from its previous extra-small version, providing a more substantial visual presence. This change offers improved visual consistency and better user perception of loading states, ensuring clarity and balance throughout the interface. Additionally, this modification supports ongoing efforts to standardize component sizing for an enhanced overall appearance.

@wingkwong wingkwong added this to the v2.7.5 milestone Mar 2, 2025
@wingkwong wingkwong requested a review from jrgarciadev as a code owner March 2, 2025 10:03
Copy link

linear bot commented Mar 2, 2025

Copy link

changeset-bot bot commented Mar 2, 2025

⚠️ No Changeset found

Latest commit: e01fd92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
heroui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2025 10:07am
heroui-sb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2025 10:07am

Copy link
Contributor

coderabbitai bot commented Mar 2, 2025

Walkthrough

This pull request updates the configuration of the indeterminate progress component story by changing the size property. The value in the component's arguments was updated from "xs" to "sm", affecting how the component renders in its indeterminate state.

Changes

File Change Summary
packages/components/progress/stories/progress.stories.tsx Updated size property in args of the Indeterminate export from "xs" to "sm"

Suggested reviewers

  • jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a95a71 and e01fd92.

📒 Files selected for processing (1)
  • packages/components/progress/stories/progress.stories.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: TypeScript
  • GitHub Check: Build
  • GitHub Check: Continuous Release
🔇 Additional comments (1)
packages/components/progress/stories/progress.stories.tsx (1)

111-111: Correct fix for invalid size value in Indeterminate story.

The change from "xs" to "sm" properly aligns with the available size options defined in argTypes at line 27-28, which only include "sm", "md", and "lg". This ensures the Indeterminate progress component renders correctly in Storybook without using an invalid size value.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Mar 2, 2025

Open in Stackblitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@4967

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@4967

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@4967

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@4967

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@4967

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@4967

@heroui/button

npm i https://pkg.pr.new/@heroui/button@4967

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@4967

@heroui/card

npm i https://pkg.pr.new/@heroui/card@4967

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@4967

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@4967

@heroui/code

npm i https://pkg.pr.new/@heroui/code@4967

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@4967

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@4967

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@4967

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@4967

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@4967

@heroui/form

npm i https://pkg.pr.new/@heroui/form@4967

@heroui/image

npm i https://pkg.pr.new/@heroui/image@4967

@heroui/input

npm i https://pkg.pr.new/@heroui/input@4967

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@4967

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@4967

@heroui/link

npm i https://pkg.pr.new/@heroui/link@4967

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@4967

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@4967

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@4967

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@4967

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@4967

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@4967

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@4967

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@4967

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@4967

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@4967

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@4967

@heroui/select

npm i https://pkg.pr.new/@heroui/select@4967

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@4967

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@4967

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@4967

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@4967

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@4967

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@4967

@heroui/table

npm i https://pkg.pr.new/@heroui/table@4967

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@4967

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@4967

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@4967

@heroui/user

npm i https://pkg.pr.new/@heroui/user@4967

@heroui/react

npm i https://pkg.pr.new/@heroui/react@4967

@heroui/system

npm i https://pkg.pr.new/@heroui/system@4967

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@4967

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@4967

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@4967

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@4967

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@4967

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@4967

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@4967

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@4967

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@4967

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@4967

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@4967

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@4967

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@4967

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@4967

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@4967

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@4967

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@4967

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@4967

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@4967

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@4967

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@4967

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@4967

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@4967

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@4967

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@4967

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@4967

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@4967

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@4967

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@4967

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@4967

@heroui/framer-utils

npm i https://pkg.pr.new/@heroui/framer-utils@4967

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@4967

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@4967

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@4967

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@4967

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@4967

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@4967

commit: e01fd92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - indeterminate progress not showing in Storybook
2 participants