Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @herp-inc/eslint-config-jest to v202409 #172

Merged
merged 2 commits into from
Sep 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@
"license": "MIT",
"devDependencies": {
"@herp-inc/eslint-config": "202409.0.0",
"@herp-inc/eslint-config-jest": "0.4.0",
"@herp-inc/eslint-config-jest": "202409.1.0",
"@herp-inc/tsconfig.json": "1.0.0",
"@types/jest": "29.5.13",
"@typescript-eslint/eslint-plugin": "7.18.0",
4 changes: 2 additions & 2 deletions src/jsx-runtime.test.tsx
Original file line number Diff line number Diff line change
@@ -673,9 +673,9 @@ describe('automatic runtime', () => {
test('conditional rendering', () => {
expect(
<div>
{/* eslint-disable-next-line @typescript-eslint/no-unnecessary-condition */}
{/* eslint-disable-next-line @typescript-eslint/no-unnecessary-condition, jest/no-conditional-in-test */}
{true && <span>shown</span>}
{/* eslint-disable-next-line @typescript-eslint/no-unnecessary-condition */}
{/* eslint-disable-next-line @typescript-eslint/no-unnecessary-condition, jest/no-conditional-in-test */}
{false && <span>hidden</span>}
{null}
{undefined}
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
@@ -339,10 +339,10 @@
resolved "https://registry.yarnpkg.com/@eslint/js/-/js-8.57.1.tgz#de633db3ec2ef6a3c89e2f19038063e8a122e2c2"
integrity sha512-d9zaMRSTIKDLhctzH12MtXvJKSSUhaHcjV+2Z+GK+EEY7XKpP5yR4x+N3TAcHTcu963nIr+TMcCb4DBCYX1z6Q==

"@herp-inc/eslint-config-jest@0.4.0":
version "0.4.0"
resolved "https://registry.yarnpkg.com/@herp-inc/eslint-config-jest/-/eslint-config-jest-0.4.0.tgz#de71118a6443d05ea0f4be4b6ba35acf3ca0dea5"
integrity sha512-44m/LnZtgAK5MZQVdVb0oOKB5eq2wCbw7l92uY+qmjTqa1oesDQN6QPHGUpROcb/EDkDtcDBsG06QK9GfQvmdw==
"@herp-inc/eslint-config-jest@202409.1.0":
version "202409.1.0"
resolved "https://registry.yarnpkg.com/@herp-inc/eslint-config-jest/-/eslint-config-jest-202409.1.0.tgz#db9aaa8dd4d1c0a7483b080c7dca2c85e20699d1"
integrity sha512-h1mXvVeGGBRsRtDzidKFFADb41L/wh7REQz1ga4eROJ2ujO7esQx/yr0WSV/VDGgPezY48tY1NLiP20dOy0VxQ==

"@herp-inc/[email protected]":
version "202409.0.0"

Unchanged files with check annotations Beta

style?: Snabbdom.Style | undefined;
};
type Modularize<Modules extends Record<string, any>> = {

Check warning on line 153 in src/jsx-runtime.ts

GitHub Actions / Build

Unexpected any. Specify a different type

Check warning on line 153 in src/jsx-runtime.ts

GitHub Actions / Build

Unexpected any. Specify a different type
[Mod in keyof Modules as Mod extends string ? `$${Mod}` : never]?: Modules[Mod] | undefined;
};
type SVGElementProps<E extends SVGElement> = EventListeners<E> &
CommonProps &
Modularize<jsx.CustomModules> & { [_: string]: any };

Check warning on line 164 in src/jsx-runtime.ts

GitHub Actions / Build

Unexpected any. Specify a different type

Check warning on line 164 in src/jsx-runtime.ts

GitHub Actions / Build

Unexpected any. Specify a different type
type Target = '_self' | '_blank' | '_parent' | '_top' | Whatever;
const data: VNodeData = {};
for (const key in orig) {
const v = orig[key];

Check warning on line 1145 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value

Check warning on line 1145 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value
if (v === undefined) {
continue;
}
if (key === '$attrs' || key === 'attrs') {
data.attrs = Object.assign(v, data.attrs ?? {});

Check warning on line 1152 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value

Check warning on line 1152 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value
} else if (key.startsWith('aria-')) {
data.attrs ??= {};
data.attrs[key] = v;

Check warning on line 1155 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value

Check warning on line 1155 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value
} else if (key === 'children') {
// skip
} else if (key === '$class' || key === 'class') {
data.class = v;

Check warning on line 1159 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value

Check warning on line 1159 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value
} else if (key === 'className' || key === 'id') {
// skipping in favor of sel
} else if (key === '$data' || key === 'data' || key === 'dataset') {
data.dataset = Object.assign(v, data.dataset ?? {});

Check warning on line 1163 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value

Check warning on line 1163 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value
} else if (key.startsWith('data-')) {
const k = kebab2camel(key.replace('data-', ''));
data.dataset ??= {};
data.dataset[k] = v;

Check warning on line 1167 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value

Check warning on line 1167 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value
} else if (key === '$hook' || key === 'hook') {
data.hook = v;

Check warning on line 1169 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value

Check warning on line 1169 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value
} else if (key === 'is') {
data.is = v;

Check warning on line 1171 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value

Check warning on line 1171 in src/jsx-runtime.ts

GitHub Actions / Build

Unsafe assignment of an `any` value
} else if (key === '$key' || key === 'key') {
data.key = v;
} else if (key === '$on' || key === 'on') {