Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP ROS2 Foxy branch #4

Closed
wants to merge 7 commits into from
Closed

Conversation

AustinDeric
Copy link

@AustinDeric AustinDeric commented Sep 27, 2020

This PR shouldn't be merged, but instead should be the foxy branch.

Changes

WIP pending

  • python script conversion to ros2
  • launch file conversion
  • testing (manual, no automated test are planned in this PR)

@dniewinski
Copy link
Contributor

Hi @AustinDeric . Is this still a WIP?

@AustinDeric
Copy link
Author

AustinDeric commented Oct 30, 2020

Hi @AustinDeric . Is this still a WIP?

HI 👋 yes it is still WIP, not much left, i have some uncommitted changes locally that i will push up. I am not sure if y'all want to merge this into master or make a new foxy branch.

@dniewinski
Copy link
Contributor

Probably a foxy branch would be best. Keeping ros 1 and 2 apart might be less confusing

@Raphtor
Copy link

Raphtor commented Feb 4, 2022

What's the status on this?

@METEORITENMAX
Copy link

METEORITENMAX commented May 20, 2022

hi,
since there is no active development i started a package to port the driver to ROS 2.
The services: power_on, claim, stand, sit are working and it is possible to control the spot via the cmd_vel topic. I am planning to completely port the ros1 driver.

I somehow missed that PR when i started to port the driver. I also missed to create a fork..
If you interested we can merge this into your repo, but i am not sure how to proceed. Should I create another Draft PR?

Here is the link to our ROS 2 spot driver: https://github.com/MASKOR/spot_ros2

@heuristicus
Copy link
Owner

heuristicus commented Feb 23, 2023

Closing this. People who want a ros2 driver should use https://github.com/bdaiinstitute/spot_ros2 for the time being. I hope that it will be possible to merge the work done there and here into one repository, see bdaiinstitute/spot_ros2#25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants