Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(load_plugins): ignore plugin whose name is started with "hexo-theme" #4592

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Dec 12, 2020

What does it do?

When there are multiple hexo themes in package.json, the ones that are not activated will be loaded as plugins, which will cause errors

See also #4111

The new loading logic is to ignore all hexo-theme-* plugins, not only hexo-theme-${customThemeName}

However this goes back to the plugin name issue discussed in November 2019: #3890 (comment)

See also #4449

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@stevenjoezhang stevenjoezhang requested review from SukkaW and a team December 12, 2020 02:57
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 98.306% when pulling 99d1c38 on theme into 35ca7bb on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants