Atomically write downloaded file to filesystem #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents writing a truncated file to a valid cache path, and serving that partial file later.
This uses a new dependency, github.com/natefinch/atomic, which, from a quick look, seems to do the right thing.
I manually tested stopping the server mid-download and only complete files (builds, tarballs, and minisigs) existed in the cache, no truncated files. Upon a second download attempt, the remaining architectures were fetched and cached as usual.