WebAuth Client MVP #933
WebAuth Client MVP #933
Conversation
This is some code that should work for the WebAuth flow in theory. Unfortunately, I have no way of testing, so this code may not actually work. This commit adds a experimental web auth flow task.
|
As of right now, there are no tests due to the following issues:
|
All output is sent to the current test process. You can assert on it like this: https://github.com/hexpm/hex/blob/main/test/mix/tasks/hex.info_test.exs#L18.
If you need an endpoint on hexpm that does this you can add it here: https://github.com/hexpm/hexpm/blob/main/lib/hexpm_web/router.ex#L279-L298. |
Are you suggesting that I call the |
I am not sure what you need to do, but if you need a user to perform a webauth submit in a test scenario that could be one way of doing it. |
|
@ericmj and @wojtekmach , I have got a working task ready. Here's a video showing the task: hex_web_auth.mp4Note: I think the frame rate is slow again, but now I think it's my screen recorder's fault. |
|
@ericmj, @wojtekmach Ping. |
| Process.sleep(100) | ||
|
|
||
| task.pid | ||
| |> get_user_code |
There was a problem hiding this comment.
You can use assert_received {:mix_shell, :info, [message]} to retrieve the test output.
There was a problem hiding this comment.
The test output is actually sent to the Task process, so I can't use assert_received.
The reason I need to run the task in an other process is because, I need to extract the user_code from the test output, and then submit the user_code to hexpm for the web auth task to access the key.
There was a problem hiding this comment.
How about submitting the auth request in another process instead. Would that make it easier?
There was a problem hiding this comment.
That actually would. I did not think of that.
Will implement when free.
There is no real difference between submitting the user code to hexpm in a seperate process and submitting in the test process.
This is because I can't access the task process's mailbox like normal, and I have to use Process.info to access its messages. See the get_user_code anonymous function for more info.
What would help is some way to "echo" messages sent to the task process to the test process, in which case I can just assert_recieved. However, I think this would bring more complexity than there is already existing.
This reverts commit fedb951.
We don't want to try send an access_key request more than once per second. Therefore, this commit adds support for a timeout after a request, which will be used if a request completes in less than a second.
|
I noticed that you ran the CI on the PR. The tests will fail until the backend PR has been merged. If you would like to run the tests, I suggest that you checkout the PRs locally. |
ericmj
force-pushed
the
main
branch
2 times, most recently
from
24c6c48
to
0edaffc
Compare
See hexpm/hexpm#1024.