Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup React Native Testing Library and add some tests #45

Merged
merged 10 commits into from
Aug 5, 2021
Merged

Setup React Native Testing Library and add some tests #45

merged 10 commits into from
Aug 5, 2021

Conversation

EmersonPinheiro
Copy link
Contributor

@EmersonPinheiro EmersonPinheiro commented Aug 4, 2021 •
edited by watadarkstar
Loading

Description

This PR sets up the React Native Testing Library and adds some initial tests.

Ticket Link

Closes #43
Relates to #7

How has this been tested?

Tested navigation, playing the meditations, and general using.

Android 11 - API 30 - Real Device

Checklist

  • Added a "Closes [issue number]" in the ticket link section
  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens

watadarkstar
watadarkstar requested changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@watadarkstar watadarkstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I would just get rid of the snapshot tests and rename the file names to use dot syntax Aside from that great work.

components/__tests__/Themed-test.js Outdated Show resolved Hide resolved
components/__tests__/LoadingScreen-test.js Outdated Show resolved Hide resolved
@EmersonPinheiro
Copy link
Contributor Author

I've submitted the requested changes. Hope it's enough, but please, let me know if anything more is necessary. :)

@watadarkstar
Copy link
Collaborator

watadarkstar commented Aug 5, 2021 •
edited
Loading

Looks really good! Just some small nit changes :)

@EmersonPinheiro
Copy link
Contributor Author

Done!

@watadarkstar watadarkstar self-requested a review August 5, 2021 02:23
watadarkstar
watadarkstar approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@watadarkstar watadarkstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work!

@watadarkstar watadarkstar merged commit 0607fda into heylinda:main Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watadarkstar watadarkstar watadarkstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup React Native Testing Library
2 participants
@EmersonPinheiro @watadarkstar