code analyzed

hgxin · Jan 31, 2020 · fe1fe33 · fe1fe33
1 parent dd8751f
commit fe1fe33
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 18 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -4,6 +4,7 @@ analyzer:
     - getflutter_app
     - getflutter-app-kit
     - getflutter-web-kit
+    - test/.test_coverage.dart
 
 linter:
   rules:

diff --git a/example/lib/main.dart b/example/lib/main.dart
@@ -67,7 +67,7 @@ class _MyHomePageState extends State<MyHomePage>
     'Xamarin2',
   ];
 
-  var rating = 3.5;
+  double rating = 3.5;
 
   @override
   Widget build(BuildContext context) => Scaffold(
@@ -79,7 +79,7 @@ class _MyHomePageState extends State<MyHomePage>
           gradient: LinearGradient(
             begin: Alignment.topRight,
             end: Alignment.bottomLeft,
-            stops: [0.1, 0.5, 0.7, 0.9],
+            stops: const [0.1, 0.5, 0.7, 0.9],
             colors: [
               Colors.teal[800],
               Colors.teal[600],
@@ -234,21 +234,21 @@ class _MyHomePageState extends State<MyHomePage>
             GFCard(
               content: Column(
                 children: <Widget>[
-                  GFTypography(
+                  const GFTypography(
                     text: 'Toast',
                     type: GFTypographyType.typo6,
                   ),
-                  SizedBox(
+                  const SizedBox(
                     height: 20,
                   ),
-                  SizedBox(
+                  const SizedBox(
                     height: 20,
                   ),
                   GFToast(
                     text: 'Happy New Year',
                     button: GFButton(
                       onPressed: () {
-                        print("dfr");
+                        print('dfr');
                       },
                       text: 'OK',
                       type: GFButtonType.outline,

diff --git a/lib/components/rating/gf_rating.dart b/lib/components/rating/gf_rating.dart
@@ -1,9 +1,9 @@
 import 'package:flutter/material.dart';
 
-typedef void RatingChangeCallback(double rating);
+typedef RatingChangeCallback = void Function(double rating);
 
 class GFRating extends StatelessWidget {
-  GFRating({
+  const GFRating({
     this.itemCount = 5,
     this.spacing = 0.0,
     this.rating = 0.0,
@@ -15,9 +15,7 @@ class GFRating extends StatelessWidget {
     this.filledIcon,
     this.halfFilledIcon,
     this.allowHalfRating = true,
-  }) {
-    assert(this.rating != null);
-  }
+  }) : assert(rating != null);
 
   /// defines total number of rating items
   final int itemCount;
@@ -61,7 +59,7 @@ class GFRating extends StatelessWidget {
         size: itemSize,
       );
     } else if (index > rating - (allowHalfRating ? 0.5 : 1.0) &&
-        index < rating) {
+        index <= rating) {
       icon = Icon(
         halfFilledIcon != null ? halfFilledIcon : Icons.star_half,
         color: color ?? Theme.of(context).primaryColor,
@@ -77,9 +75,10 @@ class GFRating extends StatelessWidget {
 
     return GestureDetector(
       onTap: () {
-        if (onRatingChanged != null) onRatingChanged(index + 1.0);
+        if (onRatingChanged != null) {
+          onRatingChanged(index + 1.0);
+        }
       },
-//      onHorizontalDragStart: ,
       child: icon,
     );
   }
@@ -88,9 +87,12 @@ class GFRating extends StatelessWidget {
   Widget build(BuildContext context) => Material(
         color: Colors.transparent,
         child: Wrap(
-            alignment: WrapAlignment.center,
-            spacing: spacing,
-            children: List.generate(
-                itemCount, (index) => buildRatingBar(context, index))),
+          alignment: WrapAlignment.center,
+          spacing: spacing,
+          children: List.generate(
+            itemCount,
+            (index) => buildRatingBar(context, index),
+          ),
+        ),
       );
 }