Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reproducible archives #1981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marko-bekhta
Copy link
Member

fixes #1929

Hey @DavideD 😃,
I thought while I was at it for ORM, I might as well see about Reactive....
It seems that the only thing for Reactive was to enable those two bool flags as nothing else was detected by the check. Now as for the check to make sure we don't break something along the way ... for Search/Validator and ORM I've added a check in the nightly builds, not sure about Reactive as most of the things are done with GH actions here... How would you want to handle that? (A Validator example https://ci.hibernate.org/blue/organizations/jenkins/hibernate-validator-nightly/detail/main/46/pipeline)

Also... to double check... Reactive produces only one jar (hibernate-reactive-core), right? Here's the result I get from the check:

ok=4
ko=0
okFiles="hibernate-reactive-core-2.4.1-SNAPSHOT.jar hibernate-reactive-core-2.4.1-SNAPSHOT.module hibernate-reactive-core-2.4.1-SNAPSHOT.pom hibernate-reactive-core-2.4.1-SNAPSHOT-sources.jar"
koFiles=""

@DavideD
Copy link
Member

DavideD commented Sep 9, 2024

Thanks. I'm a bit late on this but I'm going to have a look at it soon.
By the way, you left ORM in the comments, but I'm assuming it should be `Reactive

@DavideD DavideD changed the title [#1929] Enable reproducible archives Enable reproducible archives Sep 9, 2024
@marko-bekhta
Copy link
Member Author

right ... fixed the comments 🙈 sorry
Let me know if you want the check to run on Jenkins or as GH actions ... 😃

@marko-bekhta
Copy link
Member Author

it's been a while 😄 I noticed this one while going through the list of my PRs 🙈
I've added a Jenkins job similar to the one we have for Search/Validator/ORM to test the build reproducibility in a nightly build. A test run against my repo for this job is here https://ci.hibernate.org/view/Personal%20jobs/job/hibernate-reactive-personal-marko/job/build%252Freprod-test/2/console

@DavideD
Copy link
Member

DavideD commented Jan 9, 2025

Any particular reason for this to be still a draft?

for Search/Validator and ORM I've added a check in the nightly builds, not sure about Reactive as most of the things are done with GH actions here

Hibernate Reactive also releases snapshots from CI now here: https://ci.hibernate.org/view/Reactive/job/hibernate-reactive-publish-snapshot/

Also... to double check... Reactive produces only one jar (hibernate-reactive-core), right?

Yes

@marko-bekhta marko-bekhta marked this pull request as ready for review January 9, 2025 10:18
@marko-bekhta
Copy link
Member Author

Any particular reason for this to be still a draft?

Besides me not noticing it's still a draft, no, no other reason 😃 🙈

Hibernate Reactive also releases snapshots from CI now here: https://ci.hibernate.org/view/Reactive/job/hibernate-reactive-publish-snapshot/

nice 😃👍🏻, so adding another one to CI seems like a way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable reproduceable archives
2 participants