New build system based on scikit-build-core
#383
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #383 +/- ##
=======================================
Coverage 91.40% 91.40%
=======================================
Files 72 72
Lines 12659 12659
=======================================
Hits 11571 11571
Misses 1088 1088
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I think this is ready for review. |
|
The tests are passing, but the coverage data collection is failing for some reason. I am not seeing the behavior exhibited by the runner on my Mac laptop. |
.github/workflows/ci.yml
Outdated
| @@ -88,7 +88,7 @@ jobs: | |||
| - name: Install python dependencies | |||
| run: | | |||
| sudo apt-get install graphviz graphviz-dev | |||
| pip install wheel numpy scipy f90nml h5py scikit-build cmake qsc sympy pyevtk matplotlib ninja plotly networkx pygraphviz | |||
| pip install wheel numpy scipy f90nml h5py scikit-build cmake qsc sympy pyevtk matplotlib ninja plotly networkx pygraphviz mpi4py py_spec pyoculus h5py | |||
There was a problem hiding this comment.
h5py is listed twice here.
I'm trying to remember why all these packages are manually pip installed here. Wouldn't they automatically be installed when simsopt is pip installed?
There was a problem hiding this comment.
I think it was the holdover from the initial days, when we were building wheels first and then installing from the wheels. Still that does not explain the reason. Let me clean it up.
There was a problem hiding this comment.
I checked it again. We are installing them because SPEC build requires them. SPEC installation setup is stagnant. I implemented a minimal setup when building the Python wrappers. No one updated it afterward.
| run: pip install -v .[MPI] | ||
| run: | | ||
| pip install -v . | ||
| pip install mpi4py |
There was a problem hiding this comment.
What wasn't working about the original line here? Doesn't [MPI] work for installing mpi4py?
There was a problem hiding this comment.
For some reason, mpi4py was not getting installed. The runner is acting very peculiar and I am not sure why.
| run: pip install -v .[MPI,SPEC] | ||
| run: | | ||
| pip install -v . | ||
| pip install mpi4py py_spec pyoculus h5py |
There was a problem hiding this comment.
What wasn't working about the original line here? Doesn't [MPI,SPEC] work for installing mpi4py py_spec pyoculus h5py?
There was a problem hiding this comment.
Yes. Not sure why.
|
Fixed the coverage combine issue. Still not sure why it worked before and not now. |
|
@landreman This is ready for final review. |
I replaced the deprecated
setup.pybased build framework with a new build system based onscikit-build-core, which in turn useshatchlingas its backend. All the project meta-data is now inpyproject.toml.setup.pyandsetup.cfgare removed.Pyproject.tomlcan also contain options for various tools used in the project. At present,ruffconfiguration is written to it. In the future, I'll add more configurations to it, and remove the configuration files scattered around the project.