-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute the rotational transform on a magnetic axis #399
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 91.43% 91.52% +0.08%
==========================================
Files 73 74 +1
Lines 12701 12819 +118
==========================================
+ Hits 11613 11732 +119
+ Misses 1088 1087 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about putting this function and test in simsopt.field
rather than simsopt.util
?
I've moved the |
This PR introduces functionality to compute the rotational transform on a magnetic axis, using an algorithm shared with me by @landreman and suggested by Stuart Hudson. I've put this function in
util/magnetic_axis_helpers.py
.Any suggestions of addition unit tests where the analytical rotational transform is known are welcome.