Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating ellipse surface #410

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Rotating ellipse surface #410

merged 3 commits into from
Apr 26, 2024

Conversation

landreman
Copy link
Contributor

This PR adds a convenience function to make SurfaceRZFourier surfaces that are rotating ellipses.

I decided not to make this a @classmethod so users have the option to specify either quadpoints_theta and quadpoints_phi, or specify range, nphi, and ntheta with @classmethod from_nphi_ntheta().

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.56%. Comparing base (7d88bd9) to head (b0bb926).
Report is 3 commits behind head on master.

❗ Current head b0bb926 differs from pull request most recent head bc79d97. Consider uploading reports for the commit bc79d97 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   91.10%   91.56%   +0.46%     
==========================================
  Files          74       74              
  Lines       12956    12923      -33     
==========================================
+ Hits        11803    11833      +30     
+ Misses       1153     1090      -63     
Flag Coverage Δ
unittests 91.56% <100.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rogeriojorge
rogeriojorge previously approved these changes Apr 25, 2024
Copy link
Contributor

@rogeriojorge rogeriojorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a comment on the possibility of an extra iota test.

tests/geo/test_surface_rzfourier.py Show resolved Hide resolved
@landreman landreman merged commit 21c0710 into master Apr 26, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants