Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging error in boozer.py to address #435 #436

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

landreman
Copy link
Contributor

Fix for github issue #435

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (8200130) to head (5f4509e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          75       75           
  Lines       13833    13833           
=======================================
  Hits        12799    12799           
  Misses       1034     1034           
Flag Coverage Δ
unittests 92.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rogeriojorge rogeriojorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it seems to fix the underlying bug

@landreman landreman merged commit f4b943e into master Jul 11, 2024
47 checks passed
@landreman landreman deleted the ml/boozer_logging_bug branch July 11, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants