New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logical errors and typos in Spec equilibrium object #457

Draft

missing-user wants to merge 3 commits into hiddenSymmetries:master from missing-user:master

Contributor

missing-user commented Nov 13, 2024

There were a few bugs in the Spec equilibrium object that I spotted:

Many error checks were written, but the raise clause was omitted, so they didn't take effect
The RHS of the assignments to si.iota[0:self.nvol+1] and si.oita[0:self.nvol+1] had the wrong shape
array shape check in as_spec compared tuple to list and always raised

missing-user and others added 3 commits

November 12, 2024 19:50


          Fix: raise ValueError for invalid ProfileSpec inputs, correct typos i…

2eb196d

…n logging messages in Spec class


          Merge branch 'hiddenSymmetries:master' into master

e41d792


          Fix: as_spec setter shape check typos

b47f9c1

missing-user marked this pull request as draft

November 14, 2024 15:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet