chore(TCK): Added account allowance transaction endpoint #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
…ogic in helper function Signed-off-by: ivaylogarnev-limechain <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
0xivanov
reviewed
Jan 16, 2025
tck/methods/account.ts
Outdated
| const transaction = new AccountAllowanceApproveTransaction(); | ||
| transaction.setGrpcDeadline(DEFAULT_GRPC_DEADLINE); | ||
|
|
||
| const { ownerAccountId, spenderAccountId, hbar, token, nft } = |
There was a problem hiding this comment.
why work with only the 1st element?
There was a problem hiding this comment.
Added multiple allowances tests and fixed this.
Signed-off-by: ivaylogarnev-limechain <[email protected]>
…com:hashgraph/hedera-sdk-js into feat/tck-account-allowance-approve-endpoint Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
force-pushed
the
feat/tck-account-allowance-approve-endpoint
branch
from
6855080 to
7a2d1af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
AccountAllowanceApproveTransactionendpoint listed in the following issue.Related issue(s):
#2759
Checklist