java.nio.FileSystem support #859
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It just skips the build and uses the cache, and creates a new tag for the same image.
This is to work around the server closing the connections.
This allows the FileSystem to be set-up, ahead of time using newFilesystem, then to be used through Paths#get(URI) without a reference to the Filesystem itself.
This is instead of a mock.
This is needed to support an empty non-root SmbPath.
And fix a couple of small issues with said integration around directory creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly adds support for reading from SMB shares using a FileSystem implementation. It use the URI format from jcifs, to ease migrations.
It was developed on Windows, so hopefully is ok on Linux, and includes a few "fixes" to SmbStubServer for Windows and a change so it only rebuilds the docker image used for integration testing once, rather than every times it's used.